Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fixes #214] User ember-cli-babel’s public API to discover config (pl… #218

Merged
merged 1 commit into from
Jun 13, 2019
Merged

[Fixes #214] User ember-cli-babel’s public API to discover config (pl… #218

merged 1 commit into from
Jun 13, 2019

Conversation

stefanpenner
Copy link
Collaborator

@stefanpenner stefanpenner commented Jun 12, 2019 •
edited
Loading

…ugins/preset)

  • verified in offending app
  • confirm with @ef4
  • make tests green

@stefanpenner stefanpenner requested a review from ef4 June 12, 2019 16:36
@stefanpenner stefanpenner mentioned this pull request Jun 12, 2019
Closed
@stefanpenner stefanpenner force-pushed the use-ember-cli-babel-public-apis branch from 55d6e93 to d5b7824 Compare June 12, 2019 16:43
ef4
ef4 reviewed Jun 12, 2019
View reviewed changes
Copy link
Contributor

@ef4 ef4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea here that we just give up on babel config serializability?

packages/compat/src/v1-app.ts Outdated Show resolved Hide resolved
packages/compat/src/v1-app.ts Show resolved Hide resolved
@stefanpenner
Copy link
Collaborator Author

Is the idea here that we just give up on babel config serializability?

The config should be serializable:

@stefanpenner stefanpenner force-pushed the use-ember-cli-babel-public-apis branch from d5b7824 to cc35706 Compare June 12, 2019 17:03
@stefanpenner stefanpenner force-pushed the use-ember-cli-babel-public-apis branch from cc35706 to 3755e19 Compare June 12, 2019 17:07
@ef4
Copy link
Contributor

ef4 commented Jun 12, 2019

Ah, thanks. I went looking at this has indeed already been fixed for quite a while. I think the original commit was emberjs/ember-cli-babel@a2c4784

So that's good then, I'm glad to use the real API.

@stefanpenner
Copy link
Collaborator Author

@ef4 ya, ensuring these are serializable in ember-cli-babel is important, so it has been fixed. Likely just after you made your adaptation here.

@ef4 do you mind if I merge? If you do, let me know what I can work to address said concerns.

@stefanpenner stefanpenner mentioned this pull request Jun 12, 2019
Closed
@ef4 ef4 merged commit da9b392 into master Jun 13, 2019
@ef4 ef4 deleted the use-ember-cli-babel-public-apis branch June 13, 2019 14:30
@stefanpenner stefanpenner mentioned this pull request Jun 19, 2019
Closed
stefanpenner
stefanpenner commented Jun 19, 2019
View reviewed changes
packages/compat/src/v1-app.ts
'ember-cli-babel': {
includeExternalHelpers: true,
compileModules: false,
disableDebugTooling: true,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we needed this to be false not true...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ef4 ef4 ef4 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanpenner @ef4